There are multiple factors needed in a photograph to make it work. Composition, the arrangement of the elements in the frame to create a pleasing balance for the eye. Light, the heart of every photograph and often the one thing that brings life to the end result. Light plays a part in composition along with good colour combinations if not shooting in black and white. Experience and time teach you these 2 main factors, often resulting in many failures and of the course the occasional success.